diff options
| author | Hiltjo Posthuma <hiltjo@codemadness.org> | 2017-11-03 15:31:37 +0100 |
|---|---|---|
| committer | Hiltjo Posthuma <hiltjo@codemadness.org> | 2017-11-03 21:07:02 +0100 |
| commit | 1cabeda5505dcc35d4d2ca2a09151a7c449fb401 (patch) | |
| tree | ad202761d53c00ee527e3acec24180a04d606ff6 | |
| parent | init colors using SchemeLast (diff) | |
| download | dmenu-1cabeda5505dcc35d4d2ca2a09151a7c449fb401.tar.gz dmenu-1cabeda5505dcc35d4d2ca2a09151a7c449fb401.tar.bz2 dmenu-1cabeda5505dcc35d4d2ca2a09151a7c449fb401.zip | |
fix a possible free of a uninitialize variable in paste()
Diffstat (limited to '')
| -rw-r--r-- | dmenu.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/dmenu.c b/dmenu.c index 91330f1..eae5685 100644 --- a/dmenu.c +++ b/dmenu.c @@ -467,10 +467,12 @@ paste(void) Atom da; /* we have been given the current selection, now insert it into input */ - XGetWindowProperty(dpy, win, utf8, 0, (sizeof text / 4) + 1, False, - utf8, &da, &di, &dl, &dl, (unsigned char **)&p); - insert(p, (q = strchr(p, '\n')) ? q - p : (ssize_t)strlen(p)); - XFree(p); + if (XGetWindowProperty(dpy, win, utf8, 0, (sizeof text / 4) + 1, False, + utf8, &da, &di, &dl, &dl, (unsigned char **)&p) + == Success && p) { + insert(p, (q = strchr(p, '\n')) ? q - p : (ssize_t)strlen(p)); + XFree(p); + } drawmenu(); } |